New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing feasible file and folder dialog options #6244
Merged
dreddy-work
merged 2 commits into
dotnet:main
from
willibrandon:5405_file_folder_dialog_options
Dec 15, 2021
Merged
Add missing feasible file and folder dialog options #6244
dreddy-work
merged 2 commits into
dotnet:main
from
willibrandon:5405_file_folder_dialog_options
Dec 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned willibrandon
Nov 28, 2021
RussKie
reviewed
Nov 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
hughbe
previously approved these changes
Nov 29, 2021
RussKie
previously approved these changes
Nov 30, 2021
RussKie
added
the
waiting-on-team
This work item needs to be discussed with team or is waiting on team action in order to proceed
label
Dec 9, 2021
dreddy-work
requested changes
Dec 13, 2021
ghost
added
the
📭 waiting-author-feedback
The team requires more information from the author
label
Dec 13, 2021
dreddy-work
removed
the
waiting-on-team
This work item needs to be discussed with team or is waiting on team action in order to proceed
label
Dec 13, 2021
ghost
removed
the
📭 waiting-author-feedback
The team requires more information from the author
label
Dec 14, 2021
RussKie
added
the
📭 waiting-author-feedback
The team requires more information from the author
label
Dec 14, 2021
ghost
removed
the
📭 waiting-author-feedback
The team requires more information from the author
label
Dec 14, 2021
RussKie
added
the
📭 waiting-author-feedback
The team requires more information from the author
label
Dec 14, 2021
ghost
removed
the
📭 waiting-author-feedback
The team requires more information from the author
label
Dec 14, 2021
dreddy-work
approved these changes
Dec 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
dreddy-work
added
the
ready-to-merge
PRs that are ready to merge but worth notifying the internal team.
label
Dec 14, 2021
Thank you @willibrandon . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5405
Proposed changes
Add missing feasible file and folder dialog options and expose them via public properties.
Customer Impact
Regression?
Risk
Videos
AddToRecent
Gets or sets a value indicating whether the dialog box adds the folder being selected to the recent list.
AddToRecent.mp4
CheckWriteAccess
Gets or sets a value indicating whether the dialog box verifies whether creation of the specified file will be successful. If this flag is not set, the calling application must handle errors, such as denial of access, discovered when the item is created.
TestFileCreate.mp4
ExpandedMode
Gets or sets a value indicating whether the dialog box is always opened in the expanded mode.
ExpandedMode.mp4
OkRequiresInteraction
Gets or sets a value indicating whether the OK button of the dialog box is disabled until the user navigates the view or edits the filename (if applicable). Note: Disabling of the OK button does not prevent the dialog from being submitted by the Enter key.
OkButtonNeedsInteraction.mp4
SelectReadOnly
Gets or sets a value indicating whether the dialog box allows to select read-only files.
ReadOnlyReturn.mp4
ShowHiddenFiles
Gets or sets a value indicating whether the dialog box displays hidden and system files.
ForceShowHidden.mp4
ShowPinnedPlaces
Gets or sets a value indicating whether the items shown by default in the view's navigation pane are hidden.
HidePinnedPlaces.mp4
ShowPreview
Gets or sets a value indicating whether the dialog box shows a preview for selected files.
ForcePreviewPaneOn.mp4
Test methodology
Accessibility testing
Accessibility Insights for Windows
I'm seeing FastPass automated check failures for the
FolderBrowserDialog
,OpenFileDialog
, andSaveFileDialog
prior to making this change. Based on my tests this change does not increase the number of failures detected.Test environment(s)
Microsoft Reviewers: Open in CodeFlow