Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update designer-related docs, add designer troubleshooting guide #6712

Merged
merged 1 commit into from Feb 21, 2022
Merged

Update designer-related docs, add designer troubleshooting guide #6712

merged 1 commit into from Feb 21, 2022

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Feb 18, 2022 •
edited by ghost

@RussKie RussKie added the 📚 documentation Documentation bug or improvement label Feb 18, 2022
@RussKie RussKie requested a review from a team as a code owner February 18, 2022 03:16
@ghost ghost assigned RussKie Feb 18, 2022
dreddy-work
dreddy-work reviewed Feb 18, 2022
View reviewed changes
docs/designer/net-inproc-designer.md
@@ -1,29 +1,23 @@
# Windows Forms .NET Core Designer
# How to use Windows Forms .NET Framework designer for .NET applications
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title is confusing to me. Why would we use .NET framework OOP designer for .NET (assuming core?) applications?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guide is about using the classic inproc designer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its already confusing between .NET and .NET framework and if you say .NET applications, what are they? better keep it clear as .NET framework applications here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something along the lines of How to use OOP Windows Forms .NET Framework designer for .NET Framework applications

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not what this guide is about, please read it first.
This guide is about using the .NET Framework inproc designer to design .NET 5/6/7 apps.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for correcting me. hmm. Do we still expect customers using this approach?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, until the OOP designer provides the comparable developer experience (e.g., https://github.com/dotnet/winforms/issues?q=is%3Aissue+is%3Aopen+label%3A%22area%3A+VS+designer%22) this approach will be used.

@RussKie RussKie merged commit b844f4a into dotnet:main Feb 21, 2022
@RussKie RussKie deleted the designer_troubleshooting_guide branch February 21, 2022 02:45
@RussKie RussKie added this to the 7.0 Preview3 milestone Feb 22, 2022
@dotnet dotnet locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dreddy-work dreddy-work dreddy-work left review comments

@merriemcgaw merriemcgaw Awaiting requested review from merriemcgaw

Assignees

@RussKie RussKie

Labels
📚 documentation Documentation bug or improvement
Projects
None yet
Milestone
7.0 Preview3
2 participants
@RussKie @dreddy-work