Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the TreeView respect the DoubleBuffered property #7403

Merged
merged 6 commits into from Jul 27, 2022
Merged

Make the TreeView respect the DoubleBuffered property #7403

merged 6 commits into from Jul 27, 2022

Commits on Jul 13, 2022

  1. Make the TreeView respect the DoubleBuffered property 

    Fixes dotnet#4883
    @0xC0000054
    0xC0000054 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    c36293f View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. Only update the extended styles if the value has changed

    @0xC0000054
    0xC0000054 committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    f4f00b3 View commit details
    Browse the repository at this point in the history

  2. Do not change the styles that were set by external code 

    Callers may override the TreeView OnHandleCreated method and set their
own extended styles.
    @0xC0000054
    0xC0000054 committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    0de6fb0 View commit details
    Browse the repository at this point in the history

  3. Allow the double buffering to be disabled

    @0xC0000054
    0xC0000054 committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    052d21a View commit details
    Browse the repository at this point in the history

  4. Fix the method ordering

    @0xC0000054
    0xC0000054 committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    89db47d View commit details
    Browse the repository at this point in the history

  5. Track whether the DoubleBuffered property has been set 

    This stops the TVS_EX.DOUBLEBUFFER style from being removed unless the
calling code previously set the DoubleBuffered property to true.
Unconditionally removing the TreeView extended styles would break any
derived classes that set them using P/Invoke.
    @0xC0000054
    0xC0000054 committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    0956749 View commit details
    Browse the repository at this point in the history