User32 ActivateKeyBoardLayout #7451

elachlan · 2022-07-19T07:16:29Z

Microsoft Reviewers: Open in CodeFlow

src/System.Windows.Forms.Primitives/src/System.Windows.Forms.Primitives.csproj

JeremyKuhne

Please keep a single NativeMethods.txt in the root for discoverability.

src/System.Windows.Forms.Primitives/src/NativeMethods.txt

elachlan · 2022-07-20T22:45:40Z

I performed the merge manually, I detected more zero white space and manually removed it. I suggest everyone be very careful when doing merges.

dreddy-work · 2022-07-20T23:18:54Z

src/System.Windows.Forms/src/System/Windows/Forms/InputLanguage.cs

@@ -51,7 +53,7 @@ public static InputLanguage CurrentInputLanguage
                    value = DefaultInputLanguage;
                }

-                IntPtr handleOld = User32.ActivateKeyboardLayout(value.Handle, 0);
+                HKL handleOld = PInvoke.ActivateKeyboardLayout(new HKL(value.Handle), 0);
                if (handleOld == IntPtr.Zero)


should we still comparing it with IntPtr.Zero? can we just check == 0 here?

I tried, I think the compiler doesn't like it because HKL doesn't have an implicit conversion to int? I wasn't sure what to do.

I just tried this syntax. It compiled fine when targeting .NET 6 and net472:

using Windows.Win32.UI.TextServices; HKL hkl = default; if (hkl == 0) { }

This is using CsWin32 0.2.1-beta.

HKL should have a .NULL on it, if not get the .Value and compare to 0.

HKL looks like a candidate for the IsNull property that we're supposed to generate on pointer-sized handles, per microsoft/CsWin32#206. If HKL is a handle (or a pointer) and we missed that, can you file a new issue for it?

done. microsoft/CsWin32#610

AArnott · 2022-07-21T01:13:45Z

src/System.Windows.Forms/src/System/Windows/Forms/InputLanguage.cs

@@ -51,7 +53,7 @@ public static InputLanguage CurrentInputLanguage
                    value = DefaultInputLanguage;
                }

-                IntPtr handleOld = User32.ActivateKeyboardLayout(value.Handle, 0);
+                HKL handleOld = PInvoke.ActivateKeyboardLayout(new HKL(value.Handle), 0);
                if (handleOld == IntPtr.Zero)


I just tried this syntax. It compiled fine when targeting .NET 6 and net472:

using Windows.Win32.UI.TextServices; HKL hkl = default; if (hkl == 0) { }

This is using CsWin32 0.2.1-beta.

AArnott · 2022-07-21T01:16:21Z

src/System.Windows.Forms/src/System/Windows/Forms/InputLanguage.cs

-                var handles = new IntPtr[size];
-                fixed (IntPtr* pHandles = handles)
+                var handles = new HKL[size];
+                fixed (HKL* pHandles = handles)


No need for fixed here any more. With CsWin32 you can do this:

var handles = new HKL[5]; PInvoke.GetKeyboardLayoutList(handles);

AArnott · 2022-07-21T01:44:55Z

src/System.Windows.Forms/src/System/Windows/Forms/InputLanguage.cs

-                IntPtr handleOld = User32.ActivateKeyboardLayout(value.Handle, 0);
-                if (handleOld == IntPtr.Zero)
+                HKL handleOld = PInvoke.ActivateKeyboardLayout(new HKL(value.Handle), 0);
+                if (handleOld.Value == 0)


nit: the .Value here shouldn't be required.

For me, it seems it is.

Weird. Well, I'm glad you have a workaround.

Doing a cast to nint works and there is no nint.Zero. HKL has an operator for nint, but not int. Should I just do the cast or is there a better way?

HKL handleOld = PInvoke.ActivateKeyboardLayout(new HKL(value.Handle), 0); if (handleOld == (nint)0) { throw new ArgumentException(SR.ErrorBadInputLanguage, nameof(value)); }

The cast isn't necessary in my project. Maybe it's an odd C# 11 or .NET 7 targeting thing. You can choose whatever syntax you're happiest with. They're all equivalent in the end.

Does if (handleOld == default) work?

Does if (handleOld == default) work?

yes! Well it compiles. I don't know if its the same. Would you like me to push that through?

for integral types such as int, IntPtr, etc. default == 0. So it's equivalent.

dreddy-work · 2022-07-29T17:52:12Z

@elachlan , can you resolve merge conflict?

Changes from review remove zero width space character changes from review use default instead of .value==0

Migrate PInvokes Using CsWin32 Changes from review remove zero width space character changes from review use default instead of .value==0

elachlan requested a review from a team as a code owner July 19, 2022 07:16

ghost assigned elachlan Jul 19, 2022

RussKie approved these changes Jul 19, 2022

View reviewed changes

src/System.Windows.Forms.Primitives/src/System.Windows.Forms.Primitives.csproj Outdated Show resolved Hide resolved

RussKie requested review from fernandanavamoya and JeremyKuhne July 19, 2022 10:59

RussKie added the waiting-review This item is waiting on review by one or more members of team label Jul 19, 2022

RussKie requested a review from lonitra July 19, 2022 11:17

JeremyKuhne requested changes Jul 19, 2022

View reviewed changes

ghost added 📭 waiting-author-feedback The team requires more information from the author and removed 📭 waiting-author-feedback The team requires more information from the author labels Jul 19, 2022

elachlan requested a review from JeremyKuhne July 19, 2022 23:59

lonitra requested changes Jul 20, 2022

View reviewed changes

src/System.Windows.Forms.Primitives/src/NativeMethods.txt Outdated Show resolved Hide resolved

ghost added 📭 waiting-author-feedback The team requires more information from the author and removed 📭 waiting-author-feedback The team requires more information from the author labels Jul 20, 2022

elachlan requested a review from lonitra July 20, 2022 23:10

dreddy-work reviewed Jul 20, 2022

View reviewed changes

RussKie added waiting-review This item is waiting on review by one or more members of team and removed waiting-review This item is waiting on review by one or more members of team labels Jul 21, 2022

AArnott approved these changes Jul 21, 2022

View reviewed changes

AArnott reviewed Jul 21, 2022

View reviewed changes

elachlan mentioned this pull request Jul 21, 2022

Generate HKL IsNull helper microsoft/CsWin32#610

Closed

lonitra approved these changes Jul 21, 2022

View reviewed changes

dreddy-work approved these changes Jul 29, 2022

View reviewed changes

dreddy-work added ready-to-merge PRs that are ready to merge but worth notifying the internal team. and removed waiting-review This item is waiting on review by one or more members of team labels Jul 29, 2022

Migrate PInvokes Using CsWin32

70314f5

Changes from review remove zero width space character changes from review use default instead of .value==0

elachlan force-pushed the User32-ActivateKeyboardLayout branch from 0bb7fd8 to 70314f5 Compare July 29, 2022 23:42

dreddy-work merged commit 3b508c4 into dotnet:feature/win32 Jul 30, 2022

elachlan deleted the User32-ActivateKeyboardLayout branch July 30, 2022 05:11

RussKie pushed a commit that referenced this pull request Aug 9, 2022

User32 ActivateKeyBoardLayout (#7451)

812aa47

Migrate PInvokes Using CsWin32 Changes from review remove zero width space character changes from review use default instead of .value==0

ghost locked as resolved and limited conversation to collaborators Aug 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

User32 ActivateKeyBoardLayout #7451

User32 ActivateKeyBoardLayout #7451

elachlan commented Jul 19, 2022 •

edited by ghost

Loading

JeremyKuhne left a comment

elachlan commented Jul 20, 2022

dreddy-work Jul 20, 2022

elachlan Jul 20, 2022

AArnott Jul 21, 2022

JeremyKuhne Jul 21, 2022

AArnott Jul 21, 2022

elachlan Jul 21, 2022

AArnott Jul 21, 2022

AArnott Jul 21, 2022

AArnott Jul 21, 2022

elachlan Jul 21, 2022

AArnott Jul 21, 2022

elachlan Jul 21, 2022 •

edited

Loading

AArnott Jul 21, 2022

RussKie Jul 21, 2022

elachlan Jul 21, 2022 •

edited

Loading

RussKie Jul 21, 2022

dreddy-work commented Jul 29, 2022

User32 ActivateKeyBoardLayout #7451

User32 ActivateKeyBoardLayout #7451

Conversation

elachlan commented Jul 19, 2022 • edited by ghost Loading

Microsoft Reviewers: Open in CodeFlow

JeremyKuhne left a comment

Choose a reason for hiding this comment

elachlan commented Jul 20, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elachlan Jul 21, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elachlan Jul 21, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dreddy-work commented Jul 29, 2022

elachlan commented Jul 19, 2022 •

edited by ghost

Loading

elachlan Jul 21, 2022 •

edited

Loading

elachlan Jul 21, 2022 •

edited

Loading