Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port MonthCalendarDesigner to runtime #9536

Merged
merged 4 commits into from
Jul 26, 2023
Merged

Port MonthCalendarDesigner to runtime #9536

merged 4 commits into from
Jul 26, 2023

Conversation

LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Jul 21, 2023 •
edited by ghost
Loading

Related to #4908

Proposed changes

  • Port MonthCalendarDesigner to runtime

Customer Impact

  • MonthCalendarDesigner can be designed in runtime

Regression?

  • No

Risk

  • Minimal

Screenshots

Before

image

After

MonthCalendar

Test methodology

  • Manually (added MonthCalendarDesigner to DemoConsole test app)

Test environment(s)

  • .Net 8.0.100-preview.7.23364.1
  • Windows 10 Enterprise 22H2
Microsoft Reviewers: Open in CodeFlow

@LeafShi1 LeafShi1 requested a review from a team as a code owner July 21, 2023 08:05
@ghost ghost assigned LeafShi1 Jul 21, 2023
@LeafShi1 LeafShi1 mentioned this pull request Jul 19, 2023
Closed
56 tasks
SimonZhao888
SimonZhao888 previously approved these changes Jul 21, 2023
View reviewed changes
@SimonZhao888
Copy link
Member

Please fix the error first.

@dreddy-work dreddy-work added the 📭 waiting-author-feedback The team requires more information from the author label Jul 21, 2023
@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Jul 24, 2023
SimonZhao888
SimonZhao888 previously approved these changes Jul 24, 2023
View reviewed changes
@Tanya-Solyanik
Copy link
Member

@LeafShi1 - could you please rebase this change against the .NET 9 branch

@LeafShi1 LeafShi1 changed the base branch from main to Net9.0-Test July 25, 2023 00:25
@LeafShi1 LeafShi1 dismissed stale reviews from SimonZhao888 and dmitrii-drobotov July 25, 2023 00:25

The base branch was changed.

Tanya-Solyanik
Tanya-Solyanik previously approved these changes Jul 25, 2023
View reviewed changes
@LeafShi1
Copy link
Member Author

LeafShi1 commented Jul 25, 2023 •
edited
Loading

@LeafShi1 - could you please rebase this change against the .NET 9 branch

@Tanya-Solyanik After I rebase to NET9.0-Test branch, there are a lot of changes that are not belong to the current PR, but all PR checks are passed, can I complete this PR directly?
image

Epica3055
Epica3055 previously approved these changes Jul 25, 2023
View reviewed changes
SimonZhao888
SimonZhao888 previously approved these changes Jul 25, 2023
View reviewed changes
@dreddy-work dreddy-work changed the base branch from Net9.0-Test to feature/9.0 July 25, 2023 19:06
@LeafShi1 LeafShi1 dismissed stale reviews from SimonZhao888 and Epica3055 July 25, 2023 19:10

The merge-base changed after approval.

@Tanya-Solyanik
Copy link
Member

@LeafShi1 - the extra files indicate that the new .NET 9 branch is not up to date with main. Devendar is renaming the branch and after that it should take a merge from Main, then your PR will look clean

@Tanya-Solyanik Tanya-Solyanik added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Jul 26, 2023
@dreddy-work dreddy-work merged commit 5b659e9 into dotnet:feature/9.0 Jul 26, 2023
9 checks passed
@ghost ghost removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Jul 26, 2023
@Olina-Zhang
Copy link
Member

Verified this PR in feature/9.0 branch, now MonthCalendarDesigner is supported in runtime, we can modify MonthCalendar in DemoConsole app by its some properties:
MonthCalendarDesigner

@ghost ghost locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gpetrou gpetrou gpetrou left review comments

@dreddy-work dreddy-work dreddy-work left review comments

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik approved these changes

@dmitrii-drobotov dmitrii-drobotov dmitrii-drobotov left review comments

@SimonZhao888 SimonZhao888 SimonZhao888 left review comments

@Epica3055 Epica3055 Epica3055 left review comments

Assignees

@LeafShi1 LeafShi1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@LeafShi1 @SimonZhao888 @Tanya-Solyanik @Olina-Zhang @gpetrou @dreddy-work @dmitrii-drobotov @Epica3055