-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port PropertyGridDesigner and NotifyIconDesigner to runtime #4908 #9645
Port PropertyGridDesigner and NotifyIconDesigner to runtime #4908 #9645
Conversation
61b21a1
to
eae980e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but the new functionality should go into the feature/9.0 branch because we want to stabilize the main branch. Could you please rebase your PR?
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/NotifyIconDesigner.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/NotifyIconDesigner.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/NotifyIconDesigner.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/NotifyIconDesigner.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/NotifyIconDesigner.cs
Outdated
Show resolved
Hide resolved
1700db5
to
251491b
Compare
@Epica3055, @LeafShi1 - please coordinate the fix for nullability definitions that blocks your PRs. |
…ndNotifyIconDesigner
Verified this PR in feature/9.0 branch, now PropertyGridDesigner and NotifyIconDesigner is supported in runtime, we can open NotifyIcon smarttag and modify PropertyGrid in DemoConsole app by its some properties: 9645.mp4 |
Related to #4908
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow