-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port FlowLayoutPanelDesigner to runtime #9658
Port FlowLayoutPanelDesigner to runtime #9658
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, I only added minor comments! Please follow up with nullability changes in the next PR
src/System.Windows.Forms.Design/src/System/ComponentModel/Design/FlowLayoutPanelDesigner.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/IntegrationTests/DesignSurface/DemoConsole/MainForm.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/FlowLayoutPanelDesigner .cs
Outdated
Show resolved
Hide resolved
…hub.com/LeafShi1/winforms into Issue_4908_Port_FlowLayoutPanelDesigner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Verified this PR in feature/9.0 branch, FlowLayoutPanel is supported in runtime, we can modify FlowLayoutPanel in DemoConsole app by its some properties: FlowLayoutPanelDesigner.mp4 |
* Port FlowLayoutPanelDesigner to runtime
Fixes #4908
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow