Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port FlowLayoutPanelDesigner to runtime #9658

Conversation

LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Aug 4, 2023

Fixes #4908

Proposed changes

  • Port FlowLayoutPanelDesigner to runtime

Customer Impact

  • FlowLayoutPanel can be designed in runtime

Regression?

  • No

Risk

  • Minimal

Screenshots

Before

image

After

AfterChang

Test methodology

  • Manually (added FlowLayoutPanel to DemoConsole test app)

Test environment(s)

  • .net 8.0.0-rc.1.23401.22
Microsoft Reviewers: Open in CodeFlow

@LeafShi1 LeafShi1 requested a review from a team as a code owner August 4, 2023 05:00
@ghost ghost assigned LeafShi1 Aug 4, 2023
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, I only added minor comments! Please follow up with nullability changes in the next PR

@Tanya-Solyanik Tanya-Solyanik added 📭 waiting-author-feedback The team requires more information from the author Net9.0 labels Aug 4, 2023
@Tanya-Solyanik Tanya-Solyanik added this to the .NET 9.0 milestone Aug 4, 2023
@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Aug 7, 2023
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit 7876720 into dotnet:feature/9.0 Aug 7, 2023
9 checks passed
@LeafShi1 LeafShi1 deleted the Issue_4908_Port_FlowLayoutPanelDesigner branch August 8, 2023 02:07
@Eudora-Li01
Copy link
Contributor

Verified this PR in feature/9.0 branch, FlowLayoutPanel is supported in runtime, we can modify FlowLayoutPanel in DemoConsole app by its some properties:

FlowLayoutPanelDesigner.mp4

Epica3055 pushed a commit to Epica3055/winforms that referenced this pull request Aug 15, 2023
* Port FlowLayoutPanelDesigner to runtime
@ghost ghost locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants