Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port TrackBarDesigner to runtime #9703

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Port TrackBarDesigner to runtime #9703

merged 4 commits into from
Aug 18, 2023

Conversation

LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Aug 10, 2023 •
edited by ghost
Loading

Fixes #4908

Proposed changes

  • Port TrackBarDesigner.cs to runtime

Customer Impact

  • TrackBarDesigner can be designed in runtime

Regression?

  • No

Risk

  • Minimal

Screenshots

Before

image

After

AfterChang

Test methodology

  • Manually (added TrackBarDesigner to DemoConsole test app)

Accessibility testing

Test environment(s)

  • .net 8.0.100-rc.1.23407.2
Microsoft Reviewers: Open in CodeFlow

@LeafShi1 LeafShi1 requested a review from a team as a code owner August 10, 2023 03:05
@ghost ghost assigned LeafShi1 Aug 10, 2023
@LeafShi1 LeafShi1 mentioned this pull request Aug 8, 2023
Closed
56 tasks
lonitra
lonitra reviewed Aug 14, 2023
View reviewed changes
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/TrackBarDesigner.cs Outdated Show resolved Hide resolved
SimonZhao888
SimonZhao888 previously approved these changes Aug 16, 2023
View reviewed changes
@LeafShi1 LeafShi1 changed the base branch from feature/9.0 to main August 17, 2023 06:23
@LeafShi1 LeafShi1 dismissed SimonZhao888’s stale review August 17, 2023 06:23

The base branch was changed.

@LeafShi1 LeafShi1 merged commit 0a15d2c into dotnet:main Aug 18, 2023
9 checks passed
@LeafShi1 LeafShi1 deleted the Issue_4908_Port_TrackBarDesigner branch August 18, 2023 02:02
@MandiMan
Copy link
Contributor

MandiMan commented Aug 24, 2023 •
edited
Loading

Verified this PR in Winforms main branch for .Net 9.0, now TrackBarDesigner is supported in runtime, we can modify TrackBar in DemoConsole app by its some properties:

Video.mp4

@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@halgab halgab halgab left review comments

@lonitra lonitra lonitra left review comments

@SimonZhao888 SimonZhao888 SimonZhao888 approved these changes

@Epica3055 Epica3055 Epica3055 approved these changes

@Tanya-Solyanik Tanya-Solyanik Awaiting requested review from Tanya-Solyanik

Assignees

@LeafShi1 LeafShi1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support designer capabilities at runtime
6 participants
@LeafShi1 @MandiMan @halgab @lonitra @SimonZhao888 @Epica3055