Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port ToolStripPanelDesigner, ToolStripContainerDesigner, ToolStripCon… #9750

Merged
merged 12 commits into from
Sep 4, 2023
Merged

Port ToolStripPanelDesigner, ToolStripContainerDesigner, ToolStripCon… #9750

merged 12 commits into from
Sep 4, 2023

Conversation

LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Aug 18, 2023 •
edited
Loading

Related to #4908

Proposed changes

  • Port ToolStripPanelDesigner, ToolStripContainerDesigner, ToolStripContentDesigner to runtime

Customer Impact

  • ToolStripPanelDesigner, ToolStripContainerDesigner, ToolStripContentDesigner can be designed in runtime

Regression?

  • No

Risk

  • Minimal

Screenshots

Before

image

After

AfterChang

Test methodology

  • Manually (added TrackBarDesigner to DemoConsole test app)

Test environment(s)

  • .net 8.0.0-rc.1.23416.31
Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned LeafShi1 Aug 18, 2023
@ghost ghost added the draft draft PR label Aug 18, 2023
@LeafShi1 LeafShi1 mentioned this pull request Aug 22, 2023
Closed
56 tasks
@LeafShi1 LeafShi1 marked this pull request as ready for review August 23, 2023 08:47
@LeafShi1 LeafShi1 requested a review from a team as a code owner August 23, 2023 08:47
@LeafShi1 LeafShi1 removed the draft draft PR label Aug 23, 2023
lonitra
lonitra reviewed Aug 23, 2023
View reviewed changes
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few styling related comments

...System.Windows.Forms.Design/src/System/ComponentModel/Design/ToolStripContainerActionList.cs Outdated Show resolved Hide resolved
...System.Windows.Forms.Design/src/System/ComponentModel/Design/ToolStripContainerActionList.cs Outdated Show resolved Hide resolved
...System.Windows.Forms.Design/src/System/ComponentModel/Design/ToolStripContainerActionList.cs Outdated Show resolved Hide resolved
...ows.Forms.Design/src/System/Windows/Forms/Design/Behavior/ToolStripPanelSelectionBehavior.cs Outdated Show resolved Hide resolved
...indows.Forms.Design/src/System/Windows/Forms/Design/Behavior/ToolStripPanelSelectionGlyph.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ToolStripContainerDesigner.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ToolStripContainerDesigner.cs Outdated Show resolved Hide resolved
@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label Aug 23, 2023
@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Aug 24, 2023
@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label Aug 25, 2023
@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Aug 29, 2023
lonitra
lonitra reviewed Aug 31, 2023
View reviewed changes
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments, otherwise LGTM! :)

src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ParentControlDesigner.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ToolStripContainerDesigner.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ToolStripPanelDesigner.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ToolStripPanelDesigner.cs Outdated Show resolved Hide resolved
lonitra
lonitra previously approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lonitra lonitra added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Sep 1, 2023
@Tanya-Solyanik Tanya-Solyanik added 📭 waiting-author-feedback The team requires more information from the author and removed ready-to-merge PRs that are ready to merge but worth notifying the internal team. labels Sep 1, 2023
@Tanya-Solyanik
Copy link
Member

I added an extra minor comment, please merge this PR after making the requested change.

@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Sep 4, 2023
@LeafShi1 LeafShi1 merged commit 7fb9549 into dotnet:main Sep 4, 2023
9 checks passed
@LeafShi1 LeafShi1 deleted the Issue_1908_Port_ToolStripPanel_And_ToolStripContainerDesigner branch September 4, 2023 08:04
@Philip-Wang01
Copy link
Contributor

Verified this PR in Winforms main branch for .NET 9.0, now ToolStripPanelDesigner, ToolStripContainerDesigner, ToolStripContentDesigner are supported in runtime.

test9750

@ghost ghost locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elachlan elachlan elachlan left review comments

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik left review comments

@SimonZhao888 SimonZhao888 SimonZhao888 approved these changes

@lonitra lonitra lonitra left review comments

@Epica3055 Epica3055 Awaiting requested review from Epica3055

Assignees

@LeafShi1 LeafShi1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@LeafShi1 @Tanya-Solyanik @Philip-Wang01 @elachlan @lonitra @SimonZhao888