Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port DataGridViewComboBoxColumnDesigner to runtime #9869

Conversation

LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Sep 8, 2023

Related to #4908

Proposed changes

  • Add DataGridViewComboBoxColumnDesigner.cs

Customer Impact

  • DataGridViewComboBoxColumnDesigner can be designed in runtime

Regression?

  • No

Risk

  • Minimal

Screenshots

Before

The ComboBoxColumn cannot be added to DataGridView

After

AfterChang

Test methodology

  • Manually (added DataGridViewComboBoxColumnDesigner to DemoConsole test app)

Test environment(s)

  • .net 8.0.0-rc.1.23421.3
Microsoft Reviewers: Open in CodeFlow

@dreddy-work dreddy-work merged commit 4d6f551 into dotnet:main Sep 12, 2023
9 checks passed
@LeafShi1 LeafShi1 deleted the Issue_4908_Port_DataGridViewComboBoxColumnDesigner branch September 13, 2023 01:31
@Amy-Li03
Copy link
Contributor

Amy-Li03 commented Sep 15, 2023

@LeafShi1 verified this issue from main branch with winforms repo, it was not fixed well.
There are error dialogs pop up when

  1. opening the button next to DefaultCellStyle property in Edit Columns window(hitting known issue: An error dialog pop-up when edit the DefaultCellStyle property in DataGridView control  #3047)
  2. adding column for DataGridView(hitting known issue: Column types cannot be displayed in the DataGridView's Add Column window #9870 ),
  3. choosing Data Source in SmartTag of DataGridView(no known issue to track).
    NotFixWell1

@ghost ghost locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants