-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid comparison in MSBuild's ignore-conditions mode in outer build of multitargeted project #1651
Comments
I believe this could be worked around by moving that If this doesn't meet the bar for 3.0 (I wouldn't push for it, personally), it might be better to use dotnet/msbuild#3212, but that's not yet implemented. |
Why is msbuild (or Omnisharp) evaluating the numeric condition after failing the previous Refactoring into a separate file etc. seems like a tedious approach to re-invent short-circuit evaluation of boolean operators. Can you just fix dotnet/msbuild#3212 so we can use that? |
…ode in outer build of multitargeted project This change ensures that the WindowsDesktop SDK never deals with undefined numeric values related to TFM.
Originally reported by @batzen at https://github.com/dotnet/cli/issues/12267#issuecomment-522067627
3.0.100-preview9-013744
10.0.18362.239
Problem description:
A multitargeted WPF project throws an exception when evaluated in MSBuild's "ignore conditions" mode, which is often used in design-time scenarios.
This is because while the conditions here are sufficient at build time for real projects, when conditions are ignored MSBuild thinks the project is invalid (dotnet/msbuild#4622)
wpf/packaging/Microsoft.NET.Sdk.WindowsDesktop/targets/Microsoft.NET.Sdk.WindowsDesktop.props
Lines 98 to 121 in d6c7ae5
Actual behavior:
Expected behavior:
No error
Minimal repro:
TargetFramework
with<TargetFrameworks>netcoreapp3.0;net45</TargetFrameworks>
The text was updated successfully, but these errors were encountered: