Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual Studio Crashes when Adding NetCore3 WPF DLLs to Toolbox #1852

Closed
jogibear9988 opened this issue Sep 11, 2019 · 15 comments
Closed

Visual Studio Crashes when Adding NetCore3 WPF DLLs to Toolbox #1852

jogibear9988 opened this issue Sep 11, 2019 · 15 comments
Assignees
@grubioe
Labels
issue-type-tracking-external To track dependencies with other teams or repos tenet-adoption An issue related to adoption blockers.
Milestone
Future

Comments

@jogibear9988
Copy link

Create a DotNetCore3 WPF Project (Perview9) and try to add a NetCore3 WPF CustomerControl DLL to the Visual Studio Toolbox. VS will crash.

see also: dotnetprojects/WpfExtendedToolkit#10
@jogibear9988
Copy link
Author

dotnetprojects/WpfExtendedToolkit#10 (comment)

@grubioe grubioe added this to the 3.1 milestone Sep 19, 2019
@vatsan-madhavan
Copy link
Member

vatsan-madhavan commented Sep 19, 2019 •
edited
Loading

I tried reproducing this with..

  • Visual Studio 16.4.0 Preview 2.0 [29315.20.master]
  • .NET Core 3.0.100-rc2-014256
  • extended.wpf.toolkit.3.5.0
  • A basic WPF project creating like this:
    • dotnet new globaljson --sdk-version 3.0.100-rc2-014256
    • dotnet new wpf
    • dotnet new sln
    • dotnet sln add <path/to/csproj>

After opening the solution in Visual Studio,

  • Show Toolbox
  • Right-click Toolbox, and Choose Items
  • In Choose Toolbox Items Dialog,
    • Browse and select Xceed.Wpf.AvalonDock.dll obtained from extended.wpf.toolkit.3.5.0\lib\net40
  • The Toolbox will now show many new controls, including 'Calculator'
    • Drag and Drop Calculator onto MainWindow.xaml designer surface.
      • The first attempt will fail to add the control - it will simply add a project reference and an xmlns element in MainWindow.xaml (this is normal/expected).
      • The second attempt succeeded.

image

Tried the same thing again a custom control built for netcoreapp3.0 (dotnet new wpfcustomcontrollib) - no crashes observed.

summary: no repro

@vatsan-madhavan vatsan-madhavan mentioned this issue Sep 19, 2019
Closed
@vatsan-madhavan vatsan-madhavan added the 📭 waiting-author-feedback To request more information from author. label Sep 19, 2019
@jogibear9988
Copy link
Author

@vatsan-madhavan where can i download sdk rc2 ?

@vatsan-madhavan
Copy link
Member

@vatsan-madhavan Vatsan Madhavan FTE where can i download sdk rc2 ?

It corresponds to this branch: https://dotnetcli.blob.core.windows.net/dotnet/Sdk/release/3.0.1xx/latest.version

Easiest way to install is using dotnet-install.ps1 and supply --version.

@jogibear9988
Copy link
Author

i will test with official version next week

@jogibear9988
Copy link
Author

jogibear9988 commented Sep 23, 2019 •
edited
Loading

@vatsan-madhavan

Hey it still crashes on my computer...

Using VisualStudio 16.3.0
NetCore 3.0 final

I firstly opened my WPfExtentedToolkit and compiled it.

The I Created a new NetCore WPF App, opened a Xaml File, and Added the compiled NetCore Version of the WPfExtentedToolkit to the Toolbar... Then VS hung with the message "Selected Files will be loaded..."

@vatsan-madhavan
Copy link
Member

WQbWgrZPsw

@jogibear9988
Copy link
Author

Could you also try using my extended wpf toolkit fork dll?
I‘ll look today if your way works on my system

@vatsan-madhavan
Copy link
Member

When I try to load Release\netcoreapp3.0\DotNetProjects.Wpf.Extended.Toolkit.dll from your fork in the toolbox items, VS just hangs for me (the 'loading..' progress bar never stops, and the rest of VS goes black presumably because the message pump hangs).

This is likely a VS bug - not a WPF bug. Thanks for being persistent and helping with the repro.

/cc @chabiss, @diverdan92 can one you take this forward?
/cc @grubioe, this affects a key WPF scenario - we should track its resolution.

@vatsan-madhavan vatsan-madhavan added issue-type-tracking-external To track dependencies with other teams or repos tenet-adoption An issue related to adoption blockers. and removed 📭 waiting-author-feedback To request more information from author. labels Sep 25, 2019
@vatsan-madhavan
Copy link
Member

BTW, if you are getting a crash consistently, post a crash stack here. After you start VS, attach it to a debugger (WinDbg would work nicely), then go on to recreate the crash....

@debonte
Copy link

debonte commented Sep 26, 2019

This is likely a VS bug - not a WPF bug.

@vatsan-madhavan You're correct, I filed a VS bug. I'm also seeing a hang rather than a crash.

@grubioe
Copy link
Contributor

grubioe commented Sep 27, 2019

@debonte would you mind adding the ADO ID for tracking purposes? Thanks!

@debonte
Copy link

debonte commented Sep 27, 2019

@grubioe What is ADO? The DevDiv bug number is 989666.

@grubioe
Copy link
Contributor

grubioe commented Sep 27, 2019 via email

@arpitmathur arpitmathur modified the milestones: 3.1, Future Nov 7, 2019
@grubioe
Copy link
Contributor

grubioe commented Nov 27, 2019

This has been fixed in VS 16.5

ADO 989666 has been closed.

@grubioe grubioe closed this as completed Nov 27, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@grubioe grubioe

Labels
issue-type-tracking-external To track dependencies with other teams or repos tenet-adoption An issue related to adoption blockers.
Projects
None yet
Milestone
Future
Development

No branches or pull requests
5 participants
@jogibear9988 @arpitmathur @debonte @vatsan-madhavan @grubioe