Enable SplashScreen build-action for .NET Core 3.0 #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WinFX.targets has a condition for preventing SplashScreen build-action from running on .NET Framework 3.0 - which is specified overly broadly. Rewriting this condition to be more specific fixes the problem and brings the SplashScreen build action back to .NET Core 3.0.
ghost
requested review from
ghost
added
the
rladuca
approved these changes
Jul 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #299
WinFX.targets has a condition for preventing
SplashScreenbuild-action from running on .NET Framework 3.0 - which is specified overly broadly.Rewriting this condition to be more specific fixes the problem and brings the
SplashScreenbuild action back to .NET Core 3.0.