Remove support for UseLegacyDangerousClipboardDeserializationMode
#1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
added
the
|
/cc @miguep, would appreciate it if you could take a look at this. |
weltkante
reviewed
Jul 17, 2019
src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/dataobject.cs
Show resolved
Hide resolved
|
This looks good to me aside from the comment in DataObject.cs |
rladuca
approved these changes
Jul 18, 2019
…nd permanently disallow deserialization of dangerous types. - Removes support for AppContext flag `UseLegacyDangerousClipboardDeserializationMode` - Permanently limits clipboard-deserialziation to primitive non-text types only. Fixes #1132
vatsan-madhavan
force-pushed
the
dev/vatsan/clip-serialize-harden
branch
from
2a20881
to
36ad5da
Compare
vatsan-madhavan
changed the title
UseLegacyDangerousClipboardDeserializationModeUseLegacyDangerousClipboardDeserializationMode
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove support for
UseLegacyDangerousClipboardDeserializationModeand permanently disallow deserialization of dangerous types.UseLegacyDangerousClipboardDeserializationModeFixes #1132
PS: Creating a WIP PR since this hasn't gone through enough testing yet.