Fixup core-setup dependency to have same CPD attribute as others #3514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
requested review from
|
Looks like a missing attr here. |
wtgodbe
reviewed
Sep 15, 2020
| @@ -63,7 +63,7 @@ | |||
| <Uri>https://github.com/dotnet/core-setup</Uri> | |||
| <Sha>2d163b87b605fd23ceebfb04484e5ec5f2bffc32</Sha> | |||
| </Dependency> | |||
| <Dependency Name="Microsoft.NETCore.App.Runtime.win-x64" Version="3.1.3"> | |||
| <Dependency Name="Microsoft.NETCore.App.Runtime.win-x64" Version="3.1.3" CoherentParentDependency="Microsoft.Private.Winforms"> | |||
There was a problem hiding this comment.
Should we also delete the core-setup -> wpf subscription then?
wtgodbe
approved these changes
Sep 15, 2020
| @@ -63,7 +63,7 @@ | |||
| <Uri>https://github.com/dotnet/core-setup</Uri> | |||
| <Sha>2d163b87b605fd23ceebfb04484e5ec5f2bffc32</Sha> | |||
| </Dependency> | |||
| <Dependency Name="Microsoft.NETCore.App.Runtime.win-x64" Version="3.1.3"> | |||
| <Dependency Name="Microsoft.NETCore.App.Runtime.win-x64" Version="3.1.3" CoherentParentDependency="Microsoft.Private.Winforms"> | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.