Change S.S.C primitives, only having S.S.C. #5738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
requested review from
|
@bartonjs Removing S.S.C.Primitives in WPF is resulting in build errors, could you please suggest a way? |
|
If you're building for both net6.0 and net7.0, either have both references (assuming it doesn't get upset about the unresolvable reference) or conditionally add the reference to the new library... it doesn't hurt to keep referencing primitives (just a few milliseconds more of compilation time) |
bartonjs
approved these changes
Nov 29, 2021
dipeshmsft
approved these changes
Nov 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
dotnet/runtime#61025
Main PR
dotnet/runtime#61025
Description
All of System.Security.Cryptography.Primitives have been moved
Remove references to S.S.C.Primitives as it has been moved to S.S.C
Customer Impact
Build issues
Regression
None
Testing
CI
Risk