Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable h/w acceleration in RDP #7015

Closed
wants to merge 1 commit into from
Closed

Enable h/w acceleration in RDP #7015

wants to merge 1 commit into from

Conversation

lindexi
Copy link
Contributor

@lindexi lindexi commented Sep 7, 2022 •
edited by ghost

Fixes #3215

Description

Enable h/w acceleration in RDP. See #3215

cc @vatsan-madhavan

Customer Impact

The application can use the h/w acceleration in RDP

Regression

None.

Testing

Just CI.

Risk

Medium. This will change some rendering behavior.

Microsoft Reviewers: Open in CodeFlow

@lindexi lindexi requested a review from a team as a code owner September 7, 2022 00:43
@ghost ghost assigned lindexi Sep 7, 2022
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Sep 7, 2022
@ghost ghost added the Community Contribution A label for all community Contributions label Sep 7, 2022
@singhashish-wpf
Copy link
Member

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@lindexi
Copy link
Contributor Author

lindexi commented Sep 9, 2022

@singhashish-wpf

Fetch Test Binaries

2022-09-09T04:24:08.2374460Z ##[section]Starting: Fetch Test Binaries
2022-09-09T04:24:08.3698163Z ==============================================================================
2022-09-09T04:24:08.3698597Z Task         : Download Pipeline Artifacts
2022-09-09T04:24:08.3698896Z Description  : Download build and pipeline artifacts
2022-09-09T04:24:08.3699188Z Version      : 2.198.0
2022-09-09T04:24:08.3699415Z Author       : Microsoft Corporation
2022-09-09T04:24:08.3699844Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/download-pipeline-artifact
2022-09-09T04:24:08.3700291Z ==============================================================================
2022-09-09T04:24:08.9569222Z Download from the specified build: #6988
2022-09-09T04:24:08.9596345Z Download artifact to: D:\a\_work\1\a\testbinzip\
2022-09-09T04:24:09.5767775Z ##[error]The container 28527970 could not be found.
2022-09-09T04:24:09.6118021Z ##[section]Finishing: Fetch Test Binaries

@singhashish-wpf
Copy link
Member

@lindexi yep, checking this.

@miloush
Copy link
Contributor

miloush commented Sep 13, 2022

It would be good to do some testing on this or be aware of the behavior changes. Does it need to be behind a compatibility switch?

@vatsan-madhavan
Copy link
Member

vatsan-madhavan commented Sep 13, 2022 •
edited

Wrote a comment on the issue rather than here mistakenly - #3215 (comment)

@pchaurasia14
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@dipeshmsft
Copy link
Member

@lindexi, we have already included these changes in test. We will get back to you with more details.

@lindexi
Copy link
Contributor Author

lindexi commented Dec 28, 2022

Thank you @dipeshmsft

@lindexi
Copy link
Contributor Author

lindexi commented Mar 30, 2023

Reference #7684

Kuldeep-MS
Kuldeep-MS reviewed Mar 30, 2023
View reviewed changes
src/Microsoft.DotNet.Wpf/src/WpfGfx/core/common/display.cpp
@@ -2125,7 +2125,7 @@ CDisplaySet::GetGraphicsAccelerationCaps(
*pulDisplayUniqueness = m_ulDisplayUniquenessLoader;
}

if (m_rgpDisplays.GetCount() == 0 || m_fNonLocalDevicePresent)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing the m_fNonLocalDevicePresent flag from here will enable the query for rendering tier to be returned > 0 but will not actually enable the hardware acceleration.

In the process of creating the D3DDevices there is one more condition which check if non local device is present the code fallbacks to software rendering.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kuldeep-MS Thank you, and can I close this PR after #7684 merged?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, you can close this PR now or after #7684 is merged.

@lindexi lindexi closed this Mar 30, 2023
@dotnet dotnet locked as resolved and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kuldeep-MS Kuldeep-MS Kuldeep-MS left review comments

@dipeshmsft dipeshmsft Awaiting requested review from dipeshmsft

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

@SamBent SamBent Awaiting requested review from SamBent

Assignees

@lindexi lindexi

Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage Under Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable h/w acceleration in RDP
7 participants
@lindexi @singhashish-wpf @miloush @vatsan-madhavan @pchaurasia14 @dipeshmsft @Kuldeep-MS