Fall back to Window.Title if GetWindowText fails
#7345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to recover from badly-behaving windows message hooks that may change the last error during message processing.
ghost
assigned 
ghost
requested review from
|
I have a production app that is facing this issue, and would very much appreciate this PR being approved and merged into a .NET release. |
dipeshmsft
approved these changes
Jun 28, 2023
|
@bgrainger , thanks for your contribution |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to recover from badly-behaving Windows message hooks that may change the last error during message processing.
Fixes #7344
Fixes #4181
Description
UnsafeNativeMethods.GetWindowTextmay throw if badly-behaving Windows message hooks are installed on the system, or potentially for other reasons. This can crash a WPF application.Instead of crashing, we now ignore the exception and try to fall back to using
Window.Title, which should contain the same text.Customer Impact
WPF applications can crash unpredictably. It may be possible for customers to work around it with more P/Invoke code: #6026 (comment)
Having a fix in WPF itself would be simpler for most customers.
Regression
No.
Testing
Will ship in a consumer application and monitor user crash reports.
Risk
Legitimate failures of GetWindowText (too short a buffer? something else?) might incorrectly be ignored. However, if
Window.Titleis used as a fallback, the risk seems minimal.Microsoft Reviewers: Open in CodeFlow