Remove Source Generator workaround #7396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
ghost
requested review from
dipeshmsft
approved these changes
Jan 19, 2023
|
Thank you @ThomasGoulet73 for noticing and fixing this. |
|
Thank you @dipeshmsft |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5224
Description
Removes a workaround, which disables the usage of source generator in this repo, to support VS versions older than VS2022. VS2022 is required to build this repo according to the README and AFAIK the CI also use VS2022.
Customer Impact
None. This PR changes only the build of this repo.
Regression
No.
Testing
Local build + CI.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow