Use built-in StringComparer.OrdinalIgnoreCase StringComparer #8166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ThomasGoulet73
force-pushed
the
use-built-in-ordinalignorecase-stringcomparer
branch
from
5451f5b
to
85b1d91
Compare
ThomasGoulet73
commented
Aug 31, 2023
| if (((IEqualityComparer) CU.StringCaseInsensitiveComparer).Equals( | ||
| authenticationTypeString, | ||
| Enum.GetName(typeof(AuthenticationType), AuthenticationType.Windows))) | ||
| if (string.Equals(authenticationTypeString, nameof(AuthenticationType.Windows), StringComparison.OrdinalIgnoreCase)) |
There was a problem hiding this comment.
I replaced the usage of Enum.GetName in this file with nameof since we already know the enum value at build time so Enum.GetName is unnecessary overhead.
|
LGTM |
rchauhan18
approved these changes
Sep 20, 2023
ThomasGoulet73
force-pushed
the
use-built-in-ordinalignorecase-stringcomparer
branch
from
85b1d91
to
4826b3e
Compare
|
I rebased to fix the conflicts. |
|
Thanks @ThomasGoulet73 for your contribution. |
ThomasGoulet73
deleted the
use-built-in-ordinalignorecase-stringcomparer
branch
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use built-in StringComparer.OrdinalIgnoreCase StringComparer instead of using a custom IEqualityComparer that does the same thing.
Customer Impact
None.
Regression
No.
Testing
Local build + CI.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow