Additional changes to define Value property of Setter as XAML content property #8534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
ghost
requested review from
pchaurasia14
changed the title
anjali-wpf
force-pushed
the
AdditionSetterValueChanges
branch
from
3681421
to
e856320
Compare
rchauhan18
approved these changes
Feb 20, 2024
Kuldeep-MS
requested changes
Apr 15, 2024
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Markup/KnownTypes.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Markup/StyleXamlParser.cs
Show resolved
Hide resolved
dotnet-policy-service
bot
added
📭 waiting-author-feedback
Kuldeep-MS
reviewed
Apr 17, 2024
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Setter.cs
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84
Main PR #745
Test repo changes PR here
Documentation changes PR here
Description
This PR is required to make Setter as XAML content property work during xaml compilation.
Customer Impact
This will make
ValuetheContentPropertyfor Setter in order to make the code a bit less verbose.Regression
NA
Testing
Internal testing done, no new failures encountered.
Risk
This change will affect the xaml tree depth, will make changes in wpf test repo in order to ensure appropriate test coverage to accommodate this.
Microsoft Reviewers: Open in CodeFlow