Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NRT] Annotate all XAML attributes for NRT #8676

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

halgab
Copy link
Contributor

@halgab halgab commented Jan 11, 2024

Contributes to #7563

Description

Enable nullable reference type annotations for all attributes defined inside System.Xaml

Testing

CI

Risk

Low

Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned halgab Jan 11, 2024
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jan 11, 2024
@ghost ghost requested review from dipeshmsft and singhashish-wpf January 11, 2024 20:09
@ghost ghost added the Community Contribution A label for all community Contributions label Jan 11, 2024
@ghost ghost added the draft label Jan 12, 2024
@lindexi
Copy link
Contributor

lindexi commented Jan 12, 2024

This is the very exciting job!

@halgab halgab force-pushed the attributes-xaml-nrt branch 2 times, most recently from 7c8387e to 59c52b0 Compare January 13, 2024 14:59
@halgab halgab marked this pull request as ready for review January 13, 2024 15:36
@halgab halgab requested a review from a team as a code owner January 13, 2024 15:36
@ghost ghost removed the draft label Jan 13, 2024
@rchauhan18
Copy link
Contributor

/azp run

Copy link

Pull request contains merge conflicts.

@rchauhan18 rchauhan18 merged commit 38c29bc into dotnet:main Jan 29, 2024
9 checks passed
@rchauhan18
Copy link
Contributor

Thanks @halgab for your contribution!

@halgab halgab deleted the attributes-xaml-nrt branch January 29, 2024 11:25
@github-actions github-actions bot locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Community Contribution A label for all community Contributions Included in test pass PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants