Supported MouseAction.None in xaml #8842

[MauNguyenVan]

Fixes Xaml Unsupported MouseAction.None value #8842

Microsoft Reviewers: Open in CodeFlow

[MauNguyenVan]

Hello team.
I have created a PR. It is finished, please review my code changed

[dipeshmsft]

@MauNguyenVan, the team is currently occupied with Win11 theming changes. Once we have bandwidth, we will get to your PR.

[Kuldeep-MS]

ccing @miloush

[miloush]

Yeah I don't have anything against the code change, the use case seems a bit weak because the gesture will never match anything and the desired outcome can already be achieved by omitting the attribute.

A slight design concern is that the conversion does not roundtrip. None will produce empty string (for compatibility reasons), but converting empty string back throws. Perhaps an empty string should be added as another case yielding None.

If we don't know the reason why the None value was given such a special treatment, then we don't have a good reason not to accept this change.

[MauNguyenVan]

You see. String.Empty has already proceeded before.
So, IMO it's always compatibility

wpf/src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/Command/MouseActionConverter.cs

Lines 81 to 90 in 11a9d54

	string mouseActionToken = ((string)source).Trim();
	mouseActionToken = mouseActionToken.ToUpper(CultureInfo.InvariantCulture);
	if (mouseActionToken == String.Empty)
	return MouseAction.None;
	MouseAction mouseAction = MouseAction.None;
	switch (mouseActionToken)
	{
	case "NONE" : mouseAction = MouseAction.None; break;
	case "LEFTCLICK" : mouseAction = MouseAction.LeftClick; break;

[anjali-wpf]

LGTM.

[anjali-wpf]

@MauNguyenVan - Thanks for your contribution.