Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule SA1622 error doesn't fail msbuild #3698

Closed
RenseSTA opened this issue Sep 25, 2023 · 3 comments
Closed

Rule SA1622 error doesn't fail msbuild #3698

RenseSTA opened this issue Sep 25, 2023 · 3 comments
Labels

Comments

@RenseSTA
Copy link

Ive setup analysers to run on building my application.
SA1622 doesn't work properly since it allows me to build while it has related errors. I have tried enabling other documentation rules and they work properly.
i'm on stylecop version 1.2.0-beta.507

@bjornhellander
Copy link
Contributor

Hi!

I find it a bit difficult to understand exactly what you mean:

  1. Have you configured SA1622 to report an error instead of a warning (which is the default behavior)?
  2. The title says "msbuild". Do you mean that SA1622 is reported as an error inside Visual Studio, but not when running msbuild directly?
  3. By "it allows me to build", do you mean that SA1622 is not reported at all, or is it reported as a warning instead and therefore does not fail the build?

Can you provide a link to a project where it doesn't work as expected?

@RenseSTA
Copy link
Author

SA1622 is configured to report as an error,
sa1622 is reported as an error but it does not inhibit building like the other rules set as error,
It is reported but as an error but I can still build my application.
Unfortunately I cannot share a link to the project since it is a private company project

@sharwell
Copy link
Member

@RenseSTA StyleCop Analyzers is not responsible for marking a build as failed.

If SA1622 is still being reported as a warning even though you set it as error, it should be reported here:
https://github.com/dotnet/roslyn

If SA1622 is showing up as an error, but the build is not failing, it should probably be reported here:
https://github.com/dotnet/msbuild

@sharwell sharwell closed this as not planned Won't fix, can't repro, duplicate, stale Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants