Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ValidateForm): OnValidSubmit runs before ValidateAsync #2311

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

ArgoZhang
Copy link
Collaborator

OnValidSubmit runs before ValidateAsync

Description

close #2310

@bb-auto bb-auto bot added the bug Something isn't working label Nov 2, 2023
@bb-auto bb-auto bot added this to the V7.12.0 milestone Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b658d1) 99.97% compared to head (bbb3be7) 99.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2311   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files         536      536           
  Lines       17288    17297    +9     
  Branches     3321     3324    +3     
=======================================
+ Hits        17284    17293    +9     
  Partials        4        4           
Files Coverage Δ
...azor/Components/ValidateForm/ValidateForm.razor.cs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 2247aec into main Nov 2, 2023
5 checks passed
@ArgoZhang ArgoZhang deleted the refactor-validate branch November 2, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: OnValidSubmit runs before ValidateAsync
1 participant