Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Gantt): support localization #3115

Merged
merged 1 commit into from
Mar 23, 2024
Merged

feat(Gantt): support localization #3115

merged 1 commit into from
Mar 23, 2024

Conversation

cetinbas
Copy link
Contributor

@cetinbas cetinbas commented Mar 22, 2024

…e language

support localization

Changed default language for the Gantt component. It was showing non-English month names instead of English.

Description

close #3114

Copy link

bb-auto bot commented Mar 22, 2024

Thanks for your PR, @cetinbas. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bb-auto bb-auto bot requested a review from ArgoZhang March 22, 2024 19:17
@bb-auto bb-auto bot added the bug Something isn't working label Mar 22, 2024
@bb-auto bb-auto bot added this to the v8.3.0 milestone Mar 22, 2024
@bb-auto bb-auto bot added enhancement New feature or request and removed bug Something isn't working labels Mar 23, 2024
@ArgoZhang ArgoZhang changed the title Changed default language of Gantt from hardcoded zh to current cultur… feat(Gantt): support localization Mar 23, 2024
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (4fb7dc2) to head (b439676).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3115   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         568      568           
  Lines       24534    24534           
  Branches     3547     3547           
=======================================
  Hits        24525    24525           
  Misses          4        4           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 44abb4e into dotnetcore:main Mar 23, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(Gantt): support localization
3 participants