Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FullScreenButton): show tow icons when set FullScreenIcon #3133

Merged
merged 4 commits into from
Mar 24, 2024

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Mar 24, 2024

show tow icons when set FullScreenIcon

Description

close #3132

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (ffd5ac1) to head (ffac9bb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3133   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         572      573    +1     
  Lines       24585    24589    +4     
  Branches     3550     3551    +1     
=======================================
+ Hits        24576    24580    +4     
  Misses          4        4           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 70e6ba1 into main Mar 24, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the fix-fullscreen branch March 24, 2024 07:52
@bb-auto bb-auto bot added the bug Something isn't working label Mar 24, 2024
@bb-auto bb-auto bot added this to the v8.3.0 milestone Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(FullScreenButton): show tow icons when set FullScreenIcon
1 participant