feat: do not close tab item when OnCloseTabItemAsync return false #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Tab update OnCloseTabItemAsync * Tab add Fun:BeforeCloseTabItemAsync
# Conflicts: # src/BootstrapBlazor/Components/Tab/Tab.razor.cs
|
|
Codecov Report
@@ Coverage Diff @@
## main #488 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 471 471
Lines 14836 14832 -4
=========================================
- Hits 14836 14832 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ArgoZhang
added a commit
that referenced
this pull request
Feb 6, 2023
* Tab add Fun:BeforeCloseTabItemAsync * Tab update OnCloseTabItemAsync * refactor: update parameter name * doc: update xml * refactor: 更新判断语法 * refactor: 更新判断语法 * refactor: 重构代码 * doc: 删除冗余行 * refactor: 消除警告信息 * refactor: 移除可为空约束 * refactor: 移除 index 自增长逻辑 * refactor: 重构代码 * !3795 feat(#I6CY5T): update OnCloseTabItemAsync parameter on Tab * Tab update OnCloseTabItemAsync * Tab add Fun:BeforeCloseTabItemAsync * test: add unit test for OnCloseTabItemAsync * doc: 更新文档注释 --------- Co-authored-by: flash123456789 <918127890@qq.com> Co-authored-by: 张峻凡 <918127890@qq.com>
ArgoZhang
added a commit
that referenced
this pull request
Feb 6, 2023
* Tab add Fun:BeforeCloseTabItemAsync * Tab update OnCloseTabItemAsync * refactor: update parameter name * doc: update xml * refactor: 更新判断语法 * refactor: 更新判断语法 * refactor: 重构代码 * doc: 删除冗余行 * refactor: 消除警告信息 * refactor: 移除可为空约束 * refactor: 移除 index 自增长逻辑 * refactor: 重构代码 * !3795 feat(#I6CY5T): update OnCloseTabItemAsync parameter on Tab * Tab update OnCloseTabItemAsync * Tab add Fun:BeforeCloseTabItemAsync * test: add unit test for OnCloseTabItemAsync * doc: 更新文档注释 --------- Co-authored-by: flash123456789 <918127890@qq.com> Co-authored-by: 张峻凡 <918127890@qq.com>
ArgoZhang
added a commit
that referenced
this pull request
Feb 6, 2023
* Tab add Fun:BeforeCloseTabItemAsync * Tab update OnCloseTabItemAsync * refactor: update parameter name * doc: update xml * refactor: 更新判断语法 * refactor: 更新判断语法 * refactor: 重构代码 * doc: 删除冗余行 * refactor: 消除警告信息 * refactor: 移除可为空约束 * refactor: 移除 index 自增长逻辑 * refactor: 重构代码 * !3795 feat(#I6CY5T): update OnCloseTabItemAsync parameter on Tab * Tab update OnCloseTabItemAsync * Tab add Fun:BeforeCloseTabItemAsync * test: add unit test for OnCloseTabItemAsync * doc: 更新文档注释 --------- Co-authored-by: flash123456789 <918127890@qq.com> Co-authored-by: 张峻凡 <918127890@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not close tab item when OnCloseTabItemAsync return false
Description
close #487