missing CancellationToken implemented #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh should I fix the errors? have adjusted the IEasyCachingProvider therefore the errors come very likely. |
catcherwong
requested changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
For a project of mine I needed a cache.
This library does everything I need and more.
I want to use the async functions.
There was missing for me the optional CancellationToken.
This is always quite handy.
I noticed during the implementation that not all providers support this.
Nevertheless, I added it everywhere in the function header and where the provider supported it also passed it.
I hope this "fix" or whatever comes in the next version.
Thanks a lot!