Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes and code improvements #90

Merged
merged 2 commits into from
Dec 24, 2023
Merged

Bug fixes and code improvements #90

merged 2 commits into from
Dec 24, 2023

Conversation

paulushub
Copy link
Collaborator

Description

  • Removed the private ControlLine class (no longer used as path is parsed with WPF parser)
  • Add IsDefault property to Fill and Stroke to make default fills and strokes known
  • Eliminated the 135, warning CA1416: This call site is reachable on all platforms.
  • Eliminated some "as" casts, with the new "is" syntax.

Fixes and Closes #89

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change does not require a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • .NET Framework, Version 4.0
  • .NET Framework, Version 4.5
  • .NET Framework, Version 4.6
  • .NET Framework, Version 4.7
  • .NET Framework, Version 4.8
  • .NET Core, Version 3.1
  • .NET 6 ~ 8
  • All Included Samples

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@paulushub
Bug fixes and code improvements
2c3348f 
- Fixed the issue #89
- Removed the private ControlLine class (no longer used as path is parsed with WPF parser)
- Add IsDefault property to Fill and Stroke to make default fills and strokes known
- Eliminated the 135, warning CA1416: This call site is reachable on all platforms.
- Eliminated some "as" casts, with the new "is" syntax.
@paulushub paulushub linked an issue Dec 23, 2023 that may be closed by this pull request
[BUG]6.svg display failed in example #89
Closed
@paulushub paulushub merged commit 8d01895 into dotnetprojects:develop Dec 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jogibear9988 jogibear9988 jogibear9988 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]6.svg display failed in example
2 participants
@paulushub @jogibear9988