Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an open graph meta tag to display logo of dotnetthailand #24

Closed
surrealist opened this issue Apr 10, 2021 · 7 comments · Fixed by #33
Closed

Add an open graph meta tag to display logo of dotnetthailand #24

surrealist opened this issue Apr 10, 2021 · 7 comments · Fixed by #33
Assignees

Comments

@surrealist
Copy link
Member

Problem

When post a link from dotnetthailand website to other sites (ex. Facebook)
it'll display Gastby logo but it should be dotnetthailand logo instead.

image

Solution

Add <meta> tag for og:image to every pgaes of the site.

<meta property="og:image" content="url.to/the/image" />

REF: https://ogp.me/

@aaronamm
Copy link
Member

@surrealist Thanks for opening an issue and giving a good suggestion.
BTW, we have AI logo but we are lack of graphic skill and CSS style.
If someone can help us for this, we would be appreciate it.

Here is a screenshot of AI logo file that we have.

image

@surrealist surrealist added the help wanted Extra attention is needed label Apr 11, 2021
@mennwebs
Copy link

I volunteer for this. Tomorrow will check and PR krub.

@surrealist
Copy link
Member Author

Thanks, @MennStudio. Let's me flag you as an assignee.

@surrealist surrealist assigned surrealist and mennwebs and unassigned surrealist Apr 12, 2021
@mennwebs
Copy link

mennwebs commented Apr 13, 2021

Sorry I can't PR right now. Then may be you guys just use these images instead? I create 3 versions of open graph to use.

og-img-1

og-img-2

og-img-3

And also the png logo.
dotnet-logo

@mennwebs mennwebs removed their assignment Apr 13, 2021
@surrealist
Copy link
Member Author

@MennStudio Sorry that you cannot do pull request now. Anyway you already contributed to this issue by creating a very neat and high quality design images. Thanks again.

@aaronamm
Copy link
Member

@MennStudio Thank you so much.

@surrealist surrealist self-assigned this Apr 14, 2021
surrealist added a commit to surrealist/dotnetthailand.github.io that referenced this issue Apr 14, 2021
@surrealist surrealist removed the help wanted Extra attention is needed label Apr 15, 2021
@surrealist
Copy link
Member Author

We have 2 places that can inject meta og:image to html.
First one is src/html.js that need metadata:ogImage
from config/default.js. And the second one is
src/component/Soe/Soe.js this component need
metadata:siteImage from config/config.yml

I choose the second way (Soe.js) only then our web page
will have only one meta tag for og:image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants