Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch symbols to snupkg #110

Closed
PhyxionNL opened this issue Aug 5, 2020 · 7 comments
Closed

Switch symbols to snupkg #110

PhyxionNL opened this issue Aug 5, 2020 · 7 comments

Comments

@PhyxionNL
Copy link
Collaborator

See appveyor/ci#2753 and https://help.appveyor.com/discussions/problems/27680-deployment-issue-nuget.

@PhyxionNL
Copy link
Collaborator Author

Not sure if anything needs to be flipped in AppVeyor for this, so probably best for @chmorgan to do.

@chmorgan
Copy link
Collaborator

Hmm. What is a snupkg? If anyone wants to propose a GitHub workspace file change I'll look at merging it. I saw some points about GitHub not support snupkg yet though.

@PhyxionNL
Copy link
Collaborator Author

PhyxionNL commented Aug 20, 2020

It's a normal NuGet package with symbols. Now that AppVeyor is gone it might not be needed anymore.
<IncludeSymbols>true</IncludeSymbols> will probably be enough.

@chmorgan
Copy link
Collaborator

Where do we set that? I don't see any options and can't find a mention of IncludeSymbols text in any files.

@PhyxionNL
Copy link
Collaborator Author

It belongs in the csproj, I think INCLUDE_SYMBOLS must also be set for the action, see https://github.com/brandedoutcast/publish-nuget.

@chmorgan
Copy link
Collaborator

@PhyxionNL I noticed nuget was saying a symbols package was pushed. Does this mean we are all set now and can close this issue out?

@PhyxionNL
Copy link
Collaborator Author

Yeah, it's good now it seems 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants