Appveyor

[chmorgan]

@PhyxionNL should we fix the appveyor build? Maybe we can just upgrade the visual studio version and it will be fixed? I can take a look.

[PhyxionNL]

I think we can remove it, I do not see the need to run both AppVeyor and GitHub Actions.

[PhyxionNL]

I had already removed this a while ago from README and repo, but I do not have access to 3rd party integrations so you'll need to make these changes.

[PhyxionNL]

@chmorgan This still needs to be removed.

[chmorgan]

I do like keeping more than one option open. We use several for sharppcap, GitHub workflows, Travis, circleci, azure, and Appveyor. They all offer slightly different oses and tools revs. If it becomes a big burden we can back away from appveyor, in the latest case it only took a minute to update from vs2017 to vs2019 for core 3.1 support. So I’m inclined to say we should keep it for now.

…

On Sat, Jan 30, 2021 at 4:09 AM PhyxionNL ***@***.***> wrote: @chmorgan <https://github.com/chmorgan> This still needs to be removed. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#116 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJH4AGY6AAEPCHN6LG6DOTS4PEF5ANCNFSM4USYYGUQ> .

[PhyxionNL]

I do not think we need to keep it here, nothing is using it. AppVeyor is also a hell to configure, is currently not working, and causes PRs checks to go red.

[chmorgan]

Appveyor removed, closing.

[PhyxionNL]

@chmorgan Can you try again to remove AppVeyor? It's still here and it keeps failing 🤔

• Latest .NET SDK doesn't work.
• Too Many Requests. Too Many Requests.

[chmorgan]

hmm. let me look at that.

[chmorgan]

How do you know that appveyor is failing? Are we getting emails from it? I see its still running somehow...

[chmorgan]

alright, toggled off the packet net build setting. Let me know if you are still seeing failed builds from it.

[PhyxionNL]

It's still running ☹

[chmorgan]

alright, toggled off the 'tests' setting too. I could just delete it entirely...

[PhyxionNL]

Deleting would probably be better, as it's still going.

 continuous-integration/appveyor/branch Pending — Waiting for AppVeyor build to complete 

[kayoub5]

Create an appveyor.yml with content
See https://www.appveyor.com/docs/appveyor-yml/

build: off

[PhyxionNL]

I'd rather see it removed completely, GH Actions works fine, I don't see a need to run multiple CIs here, especially when AppVeyor never works reliably 🙂