-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add RTP decoding in UdpPacket #143
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhyxionNL
requested changes
Sep 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
PhyxionNL
reviewed
Sep 27, 2021
Note that we’ve got some connection tracking in packetnet-connections repo.
It’s tcp specific now but overall the library is intended for tracking
persistent connections and this sounds like it’s a little related.
…On Wed, Sep 29, 2021 at 4:47 AM PhyxionNL ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In PacketDotNet/UdpPacket.cs
<#143 (comment)>:
> + if (PayloadTypeDestinationPortMappingList.ContainsKey(destinationPort) &&
+ PayloadTypeDestinationPortMappingList[destinationPort] == typeof(WakeOnLanPacket))
If you check the post I've linked to it says it's possible to check RTP
based on the header's version and payload type. You can possibly use more
such as the size of the payload as it should always be 32-bit aligned going
by the RFC. Also CC + length of length of the CSRC section. There's no
certain way, but that is also the case for the other packets such as DHCP
and WOL.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#143 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJH4ADUJ5BGPWMJ36TYGF3UELHA5ANCNFSM5EZ5ZHJA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
RtpFields
andRtpPacket
classes for an additional UdpPacket payload decoding based on source or destination port.