Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NDP #175

Merged
merged 2 commits into from
May 13, 2022
Merged

Add NDP #175

merged 2 commits into from
May 13, 2022

Conversation

PhyxionNL
Copy link
Collaborator

Fixes #174.

PhyxionNL
PhyxionNL commented May 13, 2022
View reviewed changes
Test/PacketType/IcmpV6PacketTest.cs
Comment on lines +168 to +171
for (int i = 0; i < 10; i++)
{
dev.GetNextPacket(out _);
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kayoub5 Is there a better way to immediately go to X packet?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I can think of

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be a useful method to add perhaps, or an additional parameter to skip X packets.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no performance benefit(the only way to skip a packet is to actually read it) , and could be done as extention method

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for convenience, I assume there are more cases where it would be useful to be able to skip some packets 😊

@PhyxionNL
Add NDP
32640bc 
Fix CI.
@PhyxionNL PhyxionNL merged commit bce667c into master May 13, 2022
@PhyxionNL PhyxionNL deleted the ndp branch May 13, 2022 17:39
@PhyxionNL PhyxionNL mentioned this pull request May 13, 2022
Closed
@Ben3094
Copy link

Ben3094 commented May 13, 2022

Wow!
Thank you 😉👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayoub5 kayoub5 kayoub5 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support to NDP
3 participants
@PhyxionNL @Ben3094 @kayoub5