Updates for FreeBSD #436
Merged
Updates for FreeBSD #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Consistency uses /usr/local/etc/zonemaster (instead of /etc/zonemaster) in all four files for FreeBSD * Use cpanm instead of cpan in Installation.pm * Minor updates for FreeBSD in Installation.pm
sandoche2k
reviewed
Jun 24, 2018
| @@ -39,7 +39,9 @@ Follow the detailed [installation instructions](docs/Installation.md). | |||
|
|
|||
| ### Configuration | |||
|
|
|||
| Zonemaster *Backend* is configured as a whole from `/etc/zonemaster/backend_config.ini`. | |||
| Zonemaster *Backend* is configured as a whole from `/etc/zonemaster/backend_config.ini` | |||
| (CentOS, Debian and Ubuntu) or `/usr/local/etc/zonemaster/backend_config.ini` | |||
There was a problem hiding this comment.
I don't remember modifying the configuration file to /usr/local ? Why did you modify the location ?
There was a problem hiding this comment.
For CentOS, Debian and Ubuntu it is still /etc/zonemaster in the installation instructions, as it has always been. For FreeBSD there was a mixture of /etc/zonemaster and /usr/local/etc/zonemaster in the instructions, and since the latter is the expected in FreeBSD I decided to make it consistently /usr/local/etc/zonemaster. That affects the installation instructions for FreeBSD and the start files for FreeBSD.
There are no changes to CentOS, Debian or Ubuntu.
There was a problem hiding this comment.
@sandoche2k, please review again.
sandoche2k
approved these changes
Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in all four files for FreeBSD