Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add auto documentation #30

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

gignsky
Copy link
Contributor

@gignsky gignsky commented May 7, 2024

I am requesting a pull into the master branch, but for good reason I think.

The only updates in this pr are twofold,

1st, An update to the readme.md with a little badge that says documentation that contains a hyperlink to the MOST LIKELY URL for the documentation (I had to guess at this since I don't have access to your account, but it should probably work)

2nd, a new github actions workflow has been added to the folder, its rather simple I think but I got it running on some other code, basically it will automatically run 'cargo doc' and then take the generated website and throw it into github pages.

NOTE: SETTINGS MIGHT NEED MODIFICATION on the repo's settings panel make sure that github pages has its source set to "Github Actions" This needs to be done PRIOR TO MERGING

@gignsky
Copy link
Contributor Author

gignsky commented May 7, 2024

NOTE: SETTINGS MIGHT NEED MODIFICATION on the repo's settings panel make sure that github pages has its source set to "Github Actions" This needs to be done PRIOR TO MERGING

REMINDER!!

@gignsky gignsky changed the base branch from master to develop May 7, 2024 20:00
Copy link
Owner

@dotunwrap dotunwrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an interesting add. Could be convenient. Can you provide steps for testing so I can test this before it's merged? Or do you have a demo you can provide?

@dotunwrap dotunwrap added documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested labels May 18, 2024
- name: Build docs
run: cargo doc
- name: Add redirect
run: echo '<meta http-equiv="refresh" content="0;url=credit_card_convenience/index.html">' > target/doc/index.html
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the significance of credit_card_convenience/index.html?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants