New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add app approvers check before create ticket #143

Merged

LeoQuote merged 1 commit into douban:master from QSummerY:app_check

Feb 7, 2023

Contributor

QSummerY commented Feb 7, 2023

观察了下，大部分审批阻塞的都是填入的app和实际app name不一致，光校验app字段意义不大

在获取获取节点审批人时，APP Owner为空的时候有两种场景：

填入的 app 不一致，从而获取不到审批人
app 正确，但确实没有应用的owner作为审批人

因此 app owner 类型审批节点的审批人不能为空，为空时不能创建ticket，后续包含app owner的审批流均优先把owenr审批作为初始审批节点


          add app approvers check before create ticket

bd7a129

LeoQuote merged commit 8e2729f into douban:master

QSummerY deleted the app_check branch

February 7, 2023 05:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment