-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename of column "row_id" -> "row_ids" #64
Comments
|
The sooner, the better. R core changed some stuff in R-devel and is now pressuring me to upload a fixed version. I can also roll back this particular change for the next update, depending on how long your refactoring will take. |
Understood, thanks for the explanation. Getting it done this week will be challenging, but we are optimistic to get the changes done and released next week. |
Great, thanks! |
@mllg I saw the mail from CRAN. We are almost done and try to release a compatible version to CRAN today. |
Done and released to CRAN in version |
Thanks! And sorry for breaking your package on short notice. |
The next mlr3 version will include a refactoring which is breaking your package.
The column "row_id" of
as.data.table.Prediction()
will be renamed to "row_ids" (c.f. mlr-org/mlr3#547).It would be great if you could update your package accordingly and implement a workaround in the fashion of the following lines to ease the transition:
Thanks and let us know if you are missing some getters or converters.
The text was updated successfully, but these errors were encountered: