Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename of column "row_id" -> "row_ids" #64

Closed
mllg opened this issue Feb 23, 2021 · 7 comments
Closed

Rename of column "row_id" -> "row_ids" #64

mllg opened this issue Feb 23, 2021 · 7 comments

Comments

@mllg
Copy link
Contributor

mllg commented Feb 23, 2021

The next mlr3 version will include a refactoring which is breaking your package.
The column "row_id" of as.data.table.Prediction() will be renamed to "row_ids" (c.f. mlr-org/mlr3#547).
It would be great if you could update your package accordingly and implement a workaround in the fashion of the following lines to ease the transition:

tab = as.data.table(prediction)
data.table::setnames(tab, old = "row_id", new = "row_ids", skip_absent = TRUE) # rename col for mlr3 <= 0.10.0

Thanks and let us know if you are missing some getters or converters.

@MalteKurz
Copy link
Member

  • Thanks for the heads up. We are currently doing a larger refactoring and will then also pick up the reported change in mlr3.
  • Is there already a planned release date for 0.11.0?

@mllg
Copy link
Contributor Author

mllg commented Feb 24, 2021

* Is there already a planned release date for `0.11.0`?

The sooner, the better. R core changed some stuff in R-devel and is now pressuring me to upload a fixed version. I can also roll back this particular change for the next update, depending on how long your refactoring will take.

@MalteKurz
Copy link
Member

* Is there already a planned release date for `0.11.0`?

The sooner, the better. R core changed some stuff in R-devel and is not pressuring me to upload a fixed version. I can also roll back this particular change for the next update, depending on how long your refactoring will take.

Understood, thanks for the explanation. Getting it done this week will be challenging, but we are optimistic to get the changes done and released next week.
So I don't see a reason for a roll-back and you can proceed with your release as planned more or less independent of us.

@mllg
Copy link
Contributor Author

mllg commented Feb 24, 2021

Great, thanks!

@MalteKurz
Copy link
Member

@mllg I saw the mail from CRAN. We are almost done and try to release a compatible version to CRAN today.

@MalteKurz
Copy link
Member

Done and released to CRAN in version 0.2.0.

@mllg
Copy link
Contributor Author

mllg commented Mar 8, 2021

Thanks! And sorry for breaking your package on short notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants