Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mismatch of slot name in as.data.table(prediction) intentional? #547

Closed
mb706 opened this issue Sep 11, 2020 · 2 comments · Fixed by #606
Closed

mismatch of slot name in as.data.table(prediction) intentional? #547

mb706 opened this issue Sep 11, 2020 · 2 comments · Fixed by #606

Comments

@mb706
Copy link
Collaborator

mb706 commented Sep 11, 2020

as.data.table(prediction) has column row_id, but the slot in the Prediction / PredictionData object is row_ids, is that intentional? What is the naming rule here?

@RaphaelS1
Copy link
Contributor

Very slightly off topic but I get very confused when to use rows and when to use row_ids. Picking one of the three and being consistent would make things much easier

@mllg
Copy link
Sponsor Member

mllg commented Jan 27, 2021

The refactoring went wrong here. I agree that we should stick to row or row_id, but I'm unsure what would be a good rule for singular and plural.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants