Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forest/Stores/Weapons can exceed viewport height on Village tab #115

Closed
Continuities opened this issue Jul 16, 2014 · 6 comments
Closed
Labels
Milestone

Comments

@Continuities
Copy link
Contributor

Now that Stores panel appears on the Village tab, the information on the right-hand side of the screen can easily exceed 700px. Not sure there's a good solution to this, short of increasing the viewport height, which I don't really want to do. Go much higher than 700px and you start scrolling on laptops with smaller screens, which I would prefer to avoid. Logging the issue, just in case anyone has a bright idea.

@jernaumorat
Copy link

jQuery GUI allows some fancy movement and shadow animations, at the cost of desimplifying the appearance of the game, they could be stacked on top of one another. On that note, it does look pretty ugly when the stores box clips through the rest of the screen when changing tabs, maybe we could find a way around that as well.

@groteworld
Copy link
Member

On the note of the stores box, there seems to be a missing animation on the Dusty path tab.

@anubisthejackle
Copy link
Contributor

It could be as simple as hooking into the scroll event and checking the height of the combined sidebars and scrolling those first, with javascript, otherwise allowing the page to scroll.

@Continuities
Copy link
Contributor Author

Hey, that's a good idea.

@anubisthejackle
Copy link
Contributor

It's the same basic concept that Facebook uses for their right hand sidebar.

@ghost
Copy link

ghost commented Jul 17, 2014

Great idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants