Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancment - Themes #210

Open
Anish-Agnihotri opened this issue Jan 12, 2015 · 17 comments
Open

Enhancment - Themes #210

Anish-Agnihotri opened this issue Jan 12, 2015 · 17 comments

Comments

@Anish-Agnihotri
Copy link

I'm all for the black and white display of adarkroom but wouldn't it be cool if there were more than one color to choose from. Maybe a variety of colors.

We could have another link on the bar at the bottom like this:
menubar

On click it could look like this NOTE - In final there will be more colors and the cancel button will not be blue:
colorblue

At the end , it could look like this:
bluetotal

If you want I could fork the repo - and start to work on this. It's a small task that would be a major improvement in v1.4 (if that's not already out)

@groteworld
Copy link
Member

I've had the idea of themes before in #171

If you'd like to implement the bigger picture of theming and turning "lights off" into a theme. I would encourage that.

@groteworld groteworld changed the title Enhancment - Colors? Enhancment - Themes Jan 12, 2015
@Anish-Agnihotri
Copy link
Author

Thanks, I'll go ahead then

@garykrige
Copy link
Contributor

Hello, I'm quite a fan of this project and this seems like a fun place to start contributing.

How's your progress here @Anish-Agnihotri

@Anish-Agnihotri
Copy link
Author

I'm just testing a few color options with family members - trying to see which hurts their eyes the least :) !

@groteworld
Copy link
Member

What about the theming framework? For sanity sake, it may be best to just check in that first with only the lights off theme and default for options. Once that is squared away, it will be easier for all to contribute new themes and will keep testing this new feature easier.

@darkcoderrises
Copy link

hi, is anybody still working on this?

@groteworld
Copy link
Member

@Anish-Agnihotri I believe is, will leave it to them to update.

@ghost
Copy link

ghost commented Feb 10, 2015

I think we shall add little pictures when your playing the game i can make them

@groteworld
Copy link
Member

Sorry, I really disagree with that idea. This is a text-based adventure. It is meant to be read and imagined what is being experienced. Color themes are as far visual as this game should go.

On Tue, Feb 10, 2015 at 1:08 AM, Ethan Klein notifications@github.com
wrote:

I think we shall ad little pictures when your playing the game i can make them

Reply to this email directly or view it on GitHub:
https://github.com/Continuities/adarkroom/issues/210#issuecomment-73649598

@ghost
Copy link

ghost commented Feb 10, 2015

sorry i was just giving an idea

is their any other case that i can help?

On Feb 9, 2015, at 10:37 PM, Blake Grotewold notifications@github.com wrote:

Sorry, I really disagree with that idea. This is a text-based adventure. It is meant to be read and imagined what is being experienced. Color themes are as far visual as this game should go.

On Tue, Feb 10, 2015 at 1:08 AM, Ethan Klein notifications@github.com
wrote:

I think we shall ad little pictures when your playing the game i can make them

Reply to this email directly or view it on GitHub:
https://github.com/Continuities/adarkroom/issues/210#issuecomment-73649598

Reply to this email directly or view it on GitHub https://github.com/Continuities/adarkroom/issues/210#issuecomment-73651802.

@groteworld
Copy link
Member

Didn't you just say you were going to work on this issue?

@Anish-Agnihotri
Copy link
Author

Sorry, I lost access to my GitHub for a while. I'll get back to developing this asap. Gimme a few days and this should be out in the next update =D.

@groteworld
Copy link
Member

Sounds good!

@Anish-Agnihotri
Copy link
Author

I haven't been available for a very long time. This can be given over to some one else if need Sorry for any inconveniences.

@tehp
Copy link
Contributor

tehp commented Feb 1, 2016

I can take this over. Have you got anything started, or am I starting fresh? @Anish-Agnihotri

@tpatat1
Copy link

tpatat1 commented Sep 19, 2017

If there is anything I can help with I would be more than happy to contribute!

@gitupofftheflooranddosomework
Copy link
Contributor

Do we think this is a good idea, technically the rules say black and white, however i can add this to the todo if we want to do it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants