Skip to content

Commit

Permalink
fix(ios): prevents overwriting of forward/backward secs (#1855)
Browse files Browse the repository at this point in the history
The previous code overwrote forward/backward skip seconds when you subsequently called updateOptions
without re-specifying the same times. This fix prevents that problem.

fix #1853
  • Loading branch information
fivecar committed Feb 1, 2023
1 parent 11137d5 commit fb594c7
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions ios/RNTrackPlayer/RNTrackPlayer.swift
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ public class RNTrackPlayer: RCTEventEmitter, AudioSessionControllerDelegate {
private let audioSessionController = AudioSessionController.shared
private var shouldEmitProgressEvent: Bool = false
private var shouldResumePlaybackAfterInterruptionEnds: Bool = false
private var forwardJumpInterval: NSNumber? = nil;
private var backwardJumpInterval: NSNumber? = nil;

// MARK: - Lifecycle Methods

Expand Down Expand Up @@ -310,12 +312,15 @@ public class RNTrackPlayer: RCTEventEmitter, AudioSessionControllerDelegate {
capabilitiesStr.append("togglePlayPause");
}

forwardJumpInterval = options["forwardJumpInterval"] as? NSNumber ?? forwardJumpInterval
backwardJumpInterval = options["backwardJumpInterval"] as? NSNumber ?? backwardJumpInterval

player.remoteCommands = capabilitiesStr
.compactMap { Capability(rawValue: $0) }
.map { capability in
capability.mapToPlayerCommand(
forwardJumpInterval: options["forwardJumpInterval"] as? NSNumber,
backwardJumpInterval: options["backwardJumpInterval"] as? NSNumber,
forwardJumpInterval: forwardJumpInterval,
backwardJumpInterval: backwardJumpInterval,
likeOptions: options["likeOptions"] as? [String: Any],
dislikeOptions: options["dislikeOptions"] as? [String: Any],
bookmarkOptions: options["bookmarkOptions"] as? [String: Any]
Expand Down

0 comments on commit fb594c7

Please sign in to comment.