fix(hooks): useProgress & usePlayback hooks #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jspizziri
changed the title
|
@puckey is there a way of accomplishing this that doesn't introduce a breaking change? |
jspizziri
reviewed
Sep 14, 2022
| @@ -131,7 +131,7 @@ export function useProgress(updateInterval = 1000) { | |||
| return () => { | |||
| mounted = false; | |||
| }; | |||
| }, [playerState, updateInterval]); | |||
| }, [isNone, updateInterval]); | |||
|
|
|||
| return state; | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Not in this way, but there is slightly more convoluted way to fix this.. Will take a look at it later
|
I'm keen to see this fixed asap, so I'll share that @puckey and I were discussing this in the discord yesterday, and the initial fix proposed which worked without any breaking changes is mentioned here: |
- (breaking) fix: usePlaybackState was incorrectly returning State.None by default. Now it returns undefined while it is waiting on the async call to TrackPlayer to resolve. This also fixes the following issue where duration was incorrectly being reported as `0`: doublesymmetry#1709 - optimization: avoid unnecessarily reevaluating the useEffect on every player state change by moving the `playerState === State.None` outside of the effect and including it as a dependency instead
puckey
force-pushed
the
fix/playback-hooks
branch
from
87b1cf9
to
b895b9c
Compare
|
How about something like this @jspizziri: b895b9c |
dcvz
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State.Noneby default. Now it returns undefined while it is waiting on the async call to TrackPlayer to resolve. This also fixes the following issue where duration was incorrectly being reported as0: Duration value is always '0' in useProgress hooks #1709playerState === State.Noneoutside of the effect and including it as a dependency instead