Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hooks): useProgress & usePlayback hooks #1723

Merged
merged 2 commits into from
Sep 14, 2022
Merged

fix(hooks): useProgress & usePlayback hooks #1723

merged 2 commits into from
Sep 14, 2022

Commits on Sep 14, 2022

  1. fix(js): fix useProgress & usePlayback hooks 

    - (breaking) fix: usePlaybackState was incorrectly returning State.None by default. Now it returns undefined while it is waiting on the async call to TrackPlayer to resolve. This also fixes the following issue where duration was incorrectly being reported as `0`: doublesymmetry#1709
- optimization: avoid unnecessarily reevaluating the useEffect on every player state change by moving the `playerState === State.None` outside of the effect and including it as a dependency instead
    @puckey
    puckey committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    f7c212f View commit details
    Browse the repository at this point in the history

  2. chore(js): make hooks fix non-breaking

    @puckey
    puckey committed Sep 14, 2022
    1 Configuration menu
    Copy the full SHA
    b895b9c View commit details
    Browse the repository at this point in the history