fix: clears queue on iOS when you call reset() #1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android always did this correctly, but iOS hasn't. You basically need to not only stop playback, but actually clear the queue, when `reset()` is called. fix doublesymmetry#1899
dcvz
approved these changes
Feb 2, 2023
|
Thanks for this @fivecar ! |
|
Glad to help! Thanks for the quick review, @dcvz ! |
shawna-donnelly
pushed a commit
to heistdotcom/react-native-track-player
that referenced
this pull request
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android always did this correctly, but iOS hasn't. You basically need to not only stop playback, but actually clear the queue, when
reset()is called.fix #1899
I'm surprised no-one ever noticed this. #1899 gives a clear repro. And you'll see from Android's code that it's always worked on that platform.