fix(ios): emit state passed to handleAudioPlayerStateChange #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (player.playerState == AudioPlayerState.failed) { | ||
| private func getPlaybackStateBodyKeyValues(state: AudioPlayerState) -> Dictionary<String, Any> { | ||
| var body: Dictionary<String, Any> = ["state": State.fromPlayerState(state: state).rawValue] | ||
| if (state == AudioPlayerState.failed) { | ||
| body["error"] = getPlaybackStateErrorKeyValues() |
There was a problem hiding this comment.
Just curious and want to learn more about the codebase; shouldn't the state be passed to the getPlaybackStateErrorKeyValues as well, if changing this? Now The state === AudioPlayerState.failed check will not be the same state as the error-values function are checking on in line 741?
shawna-donnelly
pushed a commit
to heistdotcom/react-native-track-player
that referenced
this pull request
Apr 4, 2023
shawna-donnelly
pushed a commit
to heistdotcom/react-native-track-player
that referenced
this pull request
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed double
State.Playingevents and tracked it down to this issue in ios.