-
-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Queue/Playlist API #2
Comments
For this API, I'll need the state to become more reliable, I think I'll have to remove the callback from @jasongrishkoff Are you okay with this change? |
Sounds great -- I was already firing play() inside the callback; can just run the afterwards. |
Been keeping an eye on your commits. Let me know when I can help test this out. |
The playlist implementation is almost done, I'll let you know when it's ready for testing :) |
I think it's ready, I still haven't tested everything, but it should work. |
Great! Does the Wiki need updating? |
Yes, I'll update it tomorrow |
Thx! Going to today / this weekend. |
@jasongrishkoff I didn't have time to update the API page yet, but I have created a documentation page with every API function, constant or event. I'll try to work on the API page tomorrow. Edit: It's updated now :) |
@jasongrishkoff i can't find in the documentation or source code the load() function. Is this function renamed? |
@ashokkumar88 yeah this thread is nearly 1 year old, and the API has changed a lot since then! |
Fix/add play when ready2
Fixed Error onMetadataReceived
* Add notification state event * Properly stop service when needed * Properly stop the service when needed #2 * Open app when clicking on notification * Use new KotlinAudio event * Refactor
This is not only a good idea for general design, but it also helps for better performance on Chromecast devices.
APIs that are going to change:
setMetadata()
will be removed.load()
will be accepting metadataload()
can be called multiple times. The songs will be added to the queuereset()
will now reset the queueAPIs that are going to be added:
skip()
will skip to a song based on IDskipToNext()
will skip to the next songskipToPrevious()
will skip to the previous songIt might be a good idea to rename
load()
to something elseThe text was updated successfully, but these errors were encountered: