[iOS] Add swift version to podspec #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added swift version
paubins
approved these changes
Sep 26, 2019
|
ping @dcvz @Guichaguri Can you merge this onliner fix? This will fix:
And cherry pick to 1.x branch |
edwardlai3582
added a commit
to edwardlai3582/react-native-track-player
that referenced
this pull request
Dec 24, 2019
curiousdustin
approved these changes
Apr 14, 2020
curiousdustin
changed the title
curiousdustin
added a commit
to curiousdustin/react-native-track-player
that referenced
this pull request
Apr 23, 2020
…player into bugfix/ios-events * 'dev' of github.com:react-native-kit/react-native-track-player: [iOS] Simplify Podfile [iOS] Replace git submodule with SwiftAudio podspec dependency (doublesymmetry#904) Added Discord invite link to the issue chooser Removed the old issue template Updated issue templates to the new model [iOS] Fix local images not loading on lock screen. doublesymmetry#562 (doublesymmetry#897) [iOS] Update podspec swift version to match SwiftAudio submodule. Cleanup quotes and other formatting. [iOS] Add swift version to podspec (doublesymmetry#690) [iOS] Resolve promise for updateMetadataForTrack (doublesymmetry#843) [iOS] fix: Exclude SwiftAudio unnecessary files (doublesymmetry#873) # Conflicts: # ios/RNTrackPlayer/RNTrackPlayer.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added Swift version, default version is Swift 4.0(with Auto linking)
It occur Swift compile error when building after auto link, so we need specify Swift version in pod spec (it can be fixed by manually choose Swift version above 4.2, but it is not efficiently)
I'm using react-native-track-player@2.0.0-rc13