Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor eager loading magic ✨ #123

Merged
merged 2 commits into from
Feb 26, 2022
Merged

Conversation

duncanmcclean
Copy link
Member

@duncanmcclean duncanmcclean commented Feb 26, 2022

This pull request refactors the way Runway gets the relation names which should be eager loaded in the CP & via GraphQL. This PR also includes some tests for the magic logic that we provide.

To Do

  • Refactor logic to use single method in Runway
  • Added some tests

@duncanmcclean duncanmcclean changed the base branch from 2.2 to master February 26, 2022 09:48
@duncanmcclean duncanmcclean marked this pull request as ready for review February 26, 2022 10:09
@duncanmcclean duncanmcclean merged commit 4dc294a into master Feb 26, 2022
@duncanmcclean duncanmcclean deleted the refactor-eager-loading branch February 26, 2022 10:09
@github-actions
Copy link

Released as part of v2.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant